Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the canonical URL helper method #1885

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

caendesilva
Copy link
Member

Documents the method and adds more tests

@caendesilva caendesilva force-pushed the cleanup-canonical-page-helper-method branch from effa8e9 to f9236a4 Compare July 23, 2024 15:23
@caendesilva caendesilva marked this pull request as ready for review July 23, 2024 15:23
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a248320) to head (f9236a4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1885   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1764      1764           
===========================================
  Files            182       182           
  Lines           4704      4704           
===========================================
  Hits            4704      4704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva merged commit c4f4834 into master Jul 23, 2024
25 checks passed
@caendesilva caendesilva deleted the cleanup-canonical-page-helper-method branch July 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant